Taiki Endo

triage: this can be added without API break, so there is no need to consider this as a blocker of 0.1.0.

I think it depends on the serializer. For example, in serde_json, tuple struct is treated as an array, unit struct is treated as a null, tuple variant is treated as...

I think it would be preferable to compare this with the approach discussed in https://github.com/tokio-rs/valuable/issues/43 before merging. (having both is confusing.)

As a first step, I'm planning to implement attributes like `rename`, `skip` that have non-controversial behavior and are relatively simple.

I don't think we should consider that an attribute that an equivalent is no available in serde is "non-controversial" here. I cannot easily imagine how it would work.

@Keats Good point. It definitely makes sense to provide the ability to dynamically create a pointer from str.

> Also, I wonder if it would be worth adding a method like > > ```rust > pub trait Valuable { > // ... > > fn get_pointer> { >...

> we should probably add support for floats as primitive values. I believe floats are already supported. https://github.com/tokio-rs/valuable/blob/acd1a7ea5954a68f39ddbff2231bf64243b70333/valuable/src/value.rs#L137-L157

> thoughts on if `Listable` should be fixed-sized? What does fixed-sized list in the context of valuable mean? How does it differ from `matches!(size_hint(), (x, Some(y)) if x == y)`...

IIUC, inline assembly with neither `nomem` nor `readonly` implies a (SeqCst) compiler fence ([refs](https://rust-lang.zulipchat.com/#narrow/stream/216763-project-inline-asm/topic/asm.20and.20compiler.20fences/near/274118488)), so, the current usage in this crate should not be affected. https://github.com/rust-embedded/msp430/blob/4ee7a8b461763feac33409ff67fb6df1a41142a1/src/interrupt.rs#L13 https://github.com/rust-embedded/msp430/blob/4ee7a8b461763feac33409ff67fb6df1a41142a1/src/interrupt.rs#L32 https://github.com/rust-embedded/msp430/blob/4ee7a8b461763feac33409ff67fb6df1a41142a1/src/asm.rs#L9 https://github.com/rust-embedded/msp430/blob/4ee7a8b461763feac33409ff67fb6df1a41142a1/src/asm.rs#L17