Taiki Endo

Results 938 comments of Taiki Endo

I would accept a PR to document this.

Assuming https://github.com/rust-lang/futures-rs/issues/2184 is also implemented, I think try_recv is a reasonable name here.

Thanks for working on this! > how bad are missed wake-ups in cases where panics happened somewhere? It is not ideal, but fine. (Shared is neither UnwindSafe nor RefUnwindSafe. And...

For llvm-cov, maybe related to https://github.com/rust-lang/rust/issues/91092. Could you try with `NEXTEST_TEST_THREADS=1` environment variable?

[Updated cargo-llvm-cov](https://github.com/taiki-e/cargo-llvm-cov/releases/tag/v0.5.1) to set `NEXTEST_TEST_THREADS=1` by default. --- > I also tried llvm-cov and my coverage dropped even more. FWIW, as for the difference in coverage results between grcov and...

Thanks for the suggestion! At first glance, this seems reasonable to me.

Another approach is providing a trait for pin projection and implementing it for tuples. This allows the removal of tuple-struct workaround. However, unfortunately, this approach cannot support arbitrarily sized tuples,...

> relying on feature stmt_expr_attributes FYI, you can use stream_block macro to work around stmt_expr_attributes.

> ```rust > $crate::pin_project_lite::pin_project! { > $vis struct Wrapper { > #[pin] > pub inner: T, > } > } > ``` The warning seems reasonable since you are passing...

Oh, that's odd. ~~If pin_project! is correctly downgrading visibility in the generated code, it sounds like https://github.com/rust-lang/rust/issues/77973. In that case, #78 is the correct workaround.~~ EDIT: https://github.com/taiki-e/pin-project-lite/issues/77#issuecomment-1667988850 Another possibility is...