Taiki Endo

Results 938 comments of Taiki Endo

Thanks for the PR! > Oh, hmm, I see that there are ci issues because of rayon's dependencies having build scripts(outside of the two non-deterministically failing tests I had mentioned)....

The error here is related to proc-macro, but if we fix it, it still doesn't work. ```text error[E0621]: explicit lifetime required in the type of `b` --> benches/bench.rs:6:1 | 6...

So the way described in https://github.com/async-rs/async-std/issues/70#issuecomment-528042987 may not work until scoped spawn API is implemented.

cc @yoshuawuyts @stjepang

@yoshuawuyts > I think probably the best course of action here would be to revert for now and revisit this later? Yeah, for now, I think this needs to be...

How is this different from [`copy_buf`](https://docs.rs/tokio/1.5.0/tokio/io/fn.copy_buf.html) + [`BufReader`](https://docs.rs/tokio/1.5.0/tokio/io/struct.BufReader.html)? When I look at #3726's implementation, I feel it does the equivalent thing. ```rust let mut reader = BufReader::with_capacity(size, reader); copy_buf(&mut reader,...

We need to update nix used in mio-aio first. (it also enables aio feature of nix)

> Not sure whether the base should be `master` or `0.3` The base should be`master`. https://github.com/rust-lang/futures-rs/issues/2813

Thanks for the PR. We recently received another PR similar to this one (#2840 by @coolreader18). (Although this PR is 3 futures with a post-called function in different conditions, and...

CI failures are: doctest failure: https://github.com/tokio-rs/async-backtrace/actions/runs/7439947852/job/20240413980 ``` test backtrace/src/location.rs - location::location (line 7) ... FAILED failures: ---- backtrace/src/location.rs - location::location (line 7) stdout ---- Test executable failed (exit status: 101)....