Taiki Endo

https://github.com/taiki-e/portable-atomic/pull/98 has been published in portable-atomic 1.5.0. (If you are using 0.3.x and cannot upgrade to 1.x for some reason, you can also get that change by using 0.3.20+ which...

By the way, portable-atomic now tests compatibility with cg_clif in its CI (for x86_64, aarch64, riscv64). https://github.com/taiki-e/portable-atomic/commit/4c8156ae026632bb5025ed7f657f2911ecf9426b

I have reviewed many PRs/suggestions for improving error messages in macros, and those that were rejected or not implemented basically adopted one of the following two approaches: - Annotate the...

These were intended to improve diagnostics (https://github.com/tokio-rs/tokio/pull/3766), but I would accept a patch to improve compatibility with rust-analyzer as long as there are no diagnostics regressions.

The error is occurring in mio::net::UnixStream::pair, so the actual problem is somewhere in upstream, not in tokio. https://github.com/tokio-rs/tokio/blob/88b1eb54fb66461b9f3524f4b5316241a019279a/tokio/src/signal/unix.rs#L58 - mio::net::UnixStream::pair calls several syscalls [here](https://github.com/tokio-rs/mio/blob/c2f79f6969cccb6dc0452a3f360757d9e01290ce/src/sys/unix/uds/mod.rs#L77), so [patching](https://doc.rust-lang.org/cargo/reference/overriding-dependencies.html#the-patch-section) mio and figuring out...

I think the only correct solution here is to support fallible patterns, as [tokio supports](https://docs.rs/tokio/0.3.4/tokio/macro.select.html#examples). (currently, infallible patterns are only accepted) > ```rust > // XXX: unchecked should be fine...

> sounds like something that happens with the _result_ of the future Yeah, it probably works well when combined with [`OptionFuture`](https://docs.rs/futures/0.3.8/futures/future/struct.OptionFuture.html).

Thanks for the PR. I think we should make AtomicWaker UnwindSafe (#2211) first. (like [tokio did](https://github.com/tokio-rs/tokio/pull/3689))

Thanks for the PR. What is the use case for these methods?

Unfortunately they stabilized the API with different default methods, so we can't do this in 0.3. For 0.4 there is a pinned issue mentioning this and an open PR included...