Taiki Endo

Results 938 comments of Taiki Endo

Since opt-level=z has a very low inlining threshold and actively prevents inlining, I would not be surprised if it is not inlined. Try to see if you have the same...

Thanks for the minimal reproduction. I compiled your example with the following configuration and rustc version, ```toml [dependencies] crossbeam-channel = "=0.5.8" [profile.release] lto = "fat" codegen-units = 1 ``` ```console...

If you are using `panic=unwind` only for getting backtrace, it may be possible to use [`-C force-unwind-tables`](https://doc.rust-lang.org/rustc/codegen-options/index.html#force-unwind-tables) instead (see also https://github.com/rust-lang/backtrace-rs/issues/397).

"deadline" relates to whether or not to wait for a message for how long, and I think it is reasonable to receive it if the message is immediately available. I...

Thanks for the PR. I feel this would need investigations of possible designs, their advantages and disadvantages, and how they should interact with new concepts such as reconnection (https://github.com/crossbeam-rs/crossbeam/pull/750), etc.

I would like to change this in the next breaking release. Should this be changed to return a struct given that some people rely on the current API behavior? ```rs...

IIRC, the main difference is the presence of code for the single-capacity cases (see also https://github.com/crossbeam-rs/crossbeam/issues/199#issuecomment-1019549315) and disconnect(close) support.

I think there may also be a few optimizations that are present in crossbeam but not in concurrent-queue, such as https://github.com/crossbeam-rs/crossbeam/pull/1057.

There is no way to show the affected code at this time, but the warning here probably has been fixed in v0.6.7 (https://github.com/taiki-e/cargo-llvm-cov/pull/354). Could you recheck this with v0.6.7?

From https://github.com/rust-lang/futures-rs/issues/2851#issuecomment-2066826865: > I don't intend to review everything of it, but it has bunch of very suspicious unsafe codes even at a cursory glance: [This](https://github.com/yoshuawuyts/futures-concurrency/blob/1eb7a2315aaa7c9315ffee68f474806d7ba59fd6/src/future/future_group.rs#L290) would be unsound when...