futures-rs icon indicating copy to clipboard operation
futures-rs copied to clipboard

Implement the `UnwindSafe`/`RefUnwindSafe` traits on channels

Open tomaka opened this issue 2 years ago • 1 comments

To my surprise, this trait isn't implemented on channels, even though channels are kind of a critical component to unwind safety.

See the code comment for an explanation of the reasoning.

I'm not 100% confident in what I'm doing, so feel free to summon unwind-safety experts, if there is any.

tomaka avatar Sep 09 '23 11:09 tomaka

Thanks for the PR. I think we should make AtomicWaker UnwindSafe (#2211) first. (like tokio did)

taiki-e avatar Sep 10 '23 09:09 taiki-e