rust-lang
Consider removing ArcWake, re-export std::task::Wake
The futures-task crate currently defines its own ArcWake trait, but according to #2207, the intention was always to replace it with the equivalent std::task::Wake trait as soon as that got stabilized.
However, it seems that std::task::Wake was stabilized in Rust 1.51, and the MSRV of both the futures-task and futures crates currently sit at 1.56, thanks to these three PRs from around March 2023:
- https://github.com/rust-lang/futures-rs/pull/2733
- https://github.com/rust-lang/futures-rs/pull/2730
- https://github.com/rust-lang/futures-rs/pull/2735
As such, I think it should be safe to finally remove futures::task::ArcWake and simply re-export std::task::Wake in its place, possibly renamed ArcWake to maintain backwards compatibility.
Please feel free to correct me and/or close this issue if there's any context I'm missing!
Unfortunately they stabilized the API with different default methods, so we can't do this in 0.3. For 0.4 there is a pinned issue mentioning this and an open PR included in the milestone.
Ah, that makes sense. Thanks for chiming in, @taiki-e!
EDIT: Found the PR! It seems to be: #2494