Taiki Endo

Results 938 comments of Taiki Endo

See https://github.com/rust-lang/futures-rs/issues/2508 for the previous discussion.

As mentioned in https://github.com/rust-lang/futures-rs/issues/2508#issuecomment-942407374, https://github.com/rust-lang/futures-rs/pull/2344 will unblock this.

Thanks for the PR. Which future combinator is actually needed for your use case?

Peekable's use of Fuse is due to handling stream implementations that do not handle polls well after termination. (https://github.com/rust-lang/futures-rs/pull/72#issuecomment-240607781, see also [docs](https://docs.rs/futures/latest/futures/stream/trait.Stream.html#panics)) That said, it is possible to implement it...

cc @Kobzol: Are there any options for doing this in rust-lang/team or somewhere? I was going to refer to what rust-lang/rust does in rust-lang/team, but rust.toml doesn't seem to exist...

> You need to configure [this](https://github.com/rust-lang/rust/blob/master/triagebot.toml#L646) in the [triagebot](https://github.com/rust-lang/futures-rs/blob/master/triagebot.toml) file. Thanks! I opened a PR to enable it.

Thanks for the PR! It looks like a lot of the code added here is a copy from FutureUnordered. Is it possible to replace some of them with re-exports or...

> However, it may be possible to do so by making changes within the actual FuturesUnordered module that would make it easier to reuse. I'll look into that. Yeah, I...

> I've implemented a new module futures_keyed which contains most of the code that was in futures_unordered. Thanks. > * implement more mapping types, like mapped_streams, bi_multi_map_futures, and bi_multi_map_streams, which...

At first glance, this seems reasonable to me.