Connor McLaughlin

Might want to re-check this on the latest master, I ended up redoing part of this logic anyway (https://github.com/stenzek/duckstation/commit/54c2447ff3b66b8636748ee0b68c1c0c50304b87).

Thanks! I'll get around to reviewing this soon, super busy with work this week :(

Turning it off and on at runtime isn't possible - it needs the VRAM upload as it happens. You could temporarily disable it, but fully disabling would not be recoverable....

There's still a race condition here - Bus::g_ram could go null between the if and memcpy, since the system shutdown happens on the emu thread. I've held off in fixing...

> Sorry, but you're full of shit https://writingexplained.org/idiom-dictionary/bite-the-hand-that-feeds > Having a single file has no disadvanages other than that it takes a little bit to scroll around. You're ignoring indenting,...

Second part is working as intended, old GS dumps don't include the serial.

In theory, we could have another config overlay which disables the "enable per-game settings" option, enabled by the menu option. But personally, I think such a menu option would be...

> And you can see 6 axies? how many do you want? The PS2 only had 4. Likely left/right triggers. But yeah, I see no need to complicate things with...

We use the gamecontroller API in SDL, which doesn't consider pressure for buttons, i.e. it's only binary. Edit: Do the DS2/3 kernel drivers even expose this information? For the DS2...

From what I can see, it doesn't: https://github.com/torvalds/linux/blob/68e77ffbfd06ae3ef8f2abf1c3b971383c866983/drivers/hid/hid-sony.c#L873-L879 Unless I'm not looking at the correct driver.