Connor McLaughlin

Results 302 comments of Connor McLaughlin

While it would be possible to have wildcards for CLUTs, it has a massive risk of false positives/collisions, and I think it's a terrible idea. If two textures share the...

> If we can rename one of those texture with wildcards like this 0000000000000000-4af041be9842aa32-00005a13.png This won't work. The second part of the filename is the CLUT, replacing all textures that...

I explained why this is a bad idea above. If someone wants to implement this and PR it, they're free to do so, but bumping the issue accomplishes nothing.

FYI, we didn't change any permissions, or do anything that would require moderator approval. If this is due to the SDK changing permissions, then this a *very poor* design choice....

The paste from above shows that the runtime/sdk is included in the information flathub has. Doesn't seem like a stretch that you could take the difference between permissions from the...

Right. But why does that matter? Every app that uses the SDK is going to include those permissions (which is exactly what happened here), therefore if they're problematic and would...

I didn't suggest that you did. I'm talking about the hypothetical case where you would actually want to reject an update, which I'm assuming is why it triggers a review...

Forgot to mention before, this should be added to `VMManager::WarnAboutUnsafeSettings()` as well.

Hm. That probably means it's not resetting the VM on failed load. Probably need a call to `VMManager::Reset()` on https://github.com/PCSX2/pcsx2/blob/master/pcsx2/SaveState.cpp#L1151 and https://github.com/PCSX2/pcsx2/blob/master/pcsx2/SaveState.cpp#L1166

I... don't really see why the entry point being above 32MB is an issue? Unless it's the BIOS/bootstrap replacing the hardcoded TLB mappings, and the higher address isn't mapped yet....