Markus Staab

Results 1255 comments of Markus Staab

Doctrine types have been requested before https://github.com/staabm/phpstan-dba/issues/278 I think we could just have a separate class which maps the doctrine type constant-types to phpstan types. Just a guess: Maybe we...

thanks for the report. please try enabling `debugMode` and see whether you get a usefull error. can you reproduce the error in a small repository?

Hey! nice to see you again here :-). this looks pretty solid to me. I don't have much to add. > I might have to do a bit more digging...

I think db apis have subtle differences and therefore re-using a single extension is most of the time not possible. but you could built your own PHPStan return type extension...

@craigfrancis do you agree that these are cases we should report errors for, as they hide errors in wrong escaping? do other php apis have the same problem? I checked...

I think I have seen similar code like this in my life somewhere: wrong (sql injection vulnerable): ```php $query = sprintf('SELECT CountryCode FROM City WHERE name="%s"', addslashes($mysqli, $city)); // invalid...

thanks. I agree that prepared statements is a must have. still there is a lot of vulnerable code out there, where I want to point out security issues. I will...

Did you setup a database server in CI and imported a db schema into a database? Could you reproduce your problem in a small example repository?

ok this means we can close here?