Markus Staab

Results 1224 comments of Markus Staab

ok, lets go back to the drawing board in rector its sometimes usefull to pass the phpstan config into rector e.g. - for `dynamicConstantNames` so it does not remove code...

I don't know more then whats already mentioned in https://github.com/phpstan/extension-installer/issues/78 and https://github.com/phpstan/extension-installer/issues/78 @TomasVotruba do you have anything to add?

@rvanvelzen do you have a benchmark or a concrete scenario/code-example where these changes help perf wise?

I was talking about running the tool from a php 7.2 version. If thats not easily possible I am fine with closing the issue

I will try to make my use-case more clear: we want to declare deptrac as a `require-dev` dependency. the project at hand still runs php 7.2 in production, therefore a...

it could work like that: https://tomasvotruba.com/blog/how-to-release-php-81-and-72-package-in-the-same-repository/

Is there a known problem on rector side? Or is backed enums just not yet supported?

I can do the rector impl, in case someone is able to formulate unit tests of what the expected code should look like

Me - as the author of this issue - no longer needs 7.2 compat. Feel free to close if noone else needs it

as the inital author of the issue: we are now on the next ubuntu LTS train and no longer need 7.2 compat. thanks for everyone involved.