Markus Staab

Results 1232 comments of Markus Staab

I should add, that I tried using the graphql `closingIssuesReferences` but it seems to not always report references for the mentioned case. it seems to only work sometimes.

It might be interessting to look into a worst case, like when cs-fixer needs to adjust most/all files

And how is it in regards of resouce usage in such a worst case? Memory/cpu wise?

> Running analysis on 16 cores with 10 files per process. 10 files per process sounds like small batch size. does a worker die after processing a batch or will...

Hi Jakub, great to see people interessting in adding support for new db apis. to add a new api to phpstan-dba you need 2 things: 1) adding the query-string taking...

> I am getting somewhat close to finishing stage two great news. > you won't like some parts of that :) but works like a charm so far thats totally...

Do the dibi methods really return a array or does it always return a Row object which implement ArrayAccess and therefore can be accessed like a regular array? In other...

the mentioned issue is related to how stdClass works. for concrete classes we don't have this problem. see e.g. https://github.com/staabm/phpstan-dba/blob/dc579c0c10c9522b9a321bd007a5309d7ab9b876/tests/default/data/pdo.php#L18 in which you can see we support a similar thing...

please open a PR with what you have. otherwise its just guesswork on my end

thanks for the PR. its not acceptable without a test, which fails without the fix