phpstan-dba icon indicating copy to clipboard operation
phpstan-dba copied to clipboard

feat: pgsql query plan analyzer support

Open p4veI opened this issue 3 years ago • 1 comments

Hi, it took me a while to get to this, but I finally managed to take a look at this and I'm keen for some comments regarding the features.

I might have to do a bit more digging regarding postgres indexes, as I currently think the differences are quite big and frankly I'm not sure at this point if this doesn't require a bit different approach - regarding generating tips/generating errors etc.

It's kind of hard for me to figure out if the behaviour I've built in now is somewhat similar to what the mysql analyzer is doing or not, I'll probably discuss with friends in the upcoming week.

So it's kind of a draft for now..

I also noticed pgsql cache is now ignored, what's the reason for that (I guess it complicates maintenance for building mysql features)?

p4veI avatar Nov 20 '22 19:11 p4veI

Hey!

nice to see you again here :-).

this looks pretty solid to me. I don't have much to add.

I might have to do a bit more digging regarding postgres indexes, as I currently think the differences are quite big and frankly I'm not sure at this point if this doesn't require a bit different approach - regarding generating tips/generating errors etc.

I have 0 experience with pgsql, therefore cannot judge whether this is the way to go. would be great you could double check that with your friends.

I also noticed pgsql cache is now ignored, what's the reason for that (I guess it complicates maintenance for building mysql features)?

I guess you are talking about test coverage for the record and replay functionality?

I don't have pgsql running locally and therefore rely on CI mostly for this stuff. in case we can cover more, without requiring myself to install pgsql locally is very welcome.

thank you

staabm avatar Nov 20 '22 20:11 staabm