Markus Staab
Markus Staab
There are also some special cases like method signatures which are defined in an interface.. these should not be reported in a class implementing said interface. (But maybe this ticket...
@ondrejmirtes could you rebase this branch so we can see how/whether mutation testing is doing here?
thanks. test succeeded, as this PR does not contain any `->yes()` or `->no()` invocation, which means no mutations are generated. mutation testing jobs are green as expected.
> This was discussed at length at [#128](https://github.com/sebastianbergmann/comparator/issues/128). It was working before because every closure compared equal to every other closure. I don't think that was acceptable. There's no point...
should `SprintfFunctionDynamicReturnTypeExtension` return a `ErrorType` in these cases?
the composer error is valid, as we previously inferred a non-empty-string return type, even though the sprintf pattern is not known at static analysis time. other errors are the same...
the reported phpstan error is interesstig.. it seems - depending on some unknown factor - reports that we are catching a non-throwable but ignoring this very same error by identifer...
I think its related to this `Consistency::flexEntity` call in the exception classes.. some class-alias stuff is going on there.. this might lead to a race condition depending on the order...
> I might look into it this summer. ok, what can we do to fix the build until then?
> Try to rebase on top of: [3233155](https://github.com/phpstan/phpstan-src/commit/323315554048a22e6c01d635d6c5bb68f10d5aa1) looks great, thanks