Shane Smiskol

Results 382 issues of Shane Smiskol

On certain steep hills, max gas won't be enough to move forward, so the PCM enters standstill and we start rolling back. Since vEgo is absolute, we don't know about...

bug
car
gm

This bounty is for a lateral only port merged into master with a longitudinal proof of concept (ECU disable or intercept if the camera sends longitudinal commands) - We should...

car
hyundai
car port

A PR for the Lexus ES (https://github.com/commaai/openpilot/pull/19638) was to use a bit now on a message called `BRAKE_2`, to fix occasions where `BRAKE_MODULE` didn't catch brake presses. However there exists...

bug
car
toyota

Right now we just have hardocded values for the steering speeds and some hysteresis logic to check whether we *should* be able to steer, and if the car is allowing...

cleanup
car
mazda

for cars not in `NO_STOP_TIMER_CAR`. One attempt: https://github.com/commaai/openpilot/pull/26721 Might want to clean up the `if CS.pcm_acc_status != 8:` stuff, why not just check CS.standstill?

bugfix
car
toyota

For TSS2 RAV4, we check the EPS FW version to use two different versions. However, from the online lat accel factors learned, it appears that the check doesn't totally make...

enhancement
car
toyota

enhancement
car
mazda

enhancement
car
nissan

Last ~30s seconds are cut off. Cabana shows everything though. https://connect.comma.ai/57048cfce01d9625/000000fc--9826dade24