Shane Smiskol
Shane Smiskol
- [ ] pitch compensation to prevent not enough/too much gas on hills
High speed is largely unaffected, but low speed reaches the target acceleration faster. master Corolla route: a2bddce0b6747e10/0000025b--a32628ab6b PCM comp Corolla route: a2bddce0b6747e10/0000025a--bd4dcd6aec Summary: master ``` Summary start from stop Target...
Needs testing, required for https://github.com/commaai/openpilot/pull/33384 Past PRs for history: https://github.com/commaai/openpilot/pull/29481 // https://github.com/commaai/openpilot/pull/32753
Brought to our attention from the FW bot, many Subarus return different results for the same ECU and request: ```python 1c451e9ed3c48243|2024-01-15--16-10-38: [('ecu', 'fwdCamera'), ('fwVersion', b'\x00\x00e\x9a\x00\x00\x00\x00\x00\x00'), ('address', 1927), ('subAddress', 0), ('responseAddress',...
On a 2 degree downhill, the decel was already ~-0.3 m/s^2 at 10 m/s. 96850532278bae3b/00000104--77fe0d07d3 The interp currently assumes 0.15 m/s^2 at this speed which might lead to overshooting on...
In line with the rest of the cars. Toyota was first added here at 1.5 for an unknown reason (experimental port?): https://github.com/commaai/one/pull/33 It was the second port in the car...
@deanlee interesting in checking out why some objects take so long to build? ``` time g++ -v -ftime-report -o opendbc/can/dbc.os -c -std=c++1z -DDBC_FILE_PATH='"/home/batman/threepilot/opendbc_repo/opendbc/dbc"' -g -fPIC -O2 -Wunused -Werror -Wshadow -Wno-vla-cxx-extension...
## ✅ Updating FW version database with FW from 43 dongles (26 platforms) in last 0.5 days: View table |Dongle, platform, VIN|Name from VIN 🆚 CarDocs|Segments|Bad seg tags|Good seg tags|...