Shane Smiskol

Results 382 issues of Shane Smiskol

Adds new pre-enable state when enabling at a standstill with brake depressed. Allows brake and negative accel to 0 accel, blocks positive accel, gas, interceptor. Pre-reqs (so this change isn't...

car safety

Ford is written opposite of other safety modes, so it allows no action, or set button in this case. openpilot should set the set button to 0 at all times...

car safety

Split from https://github.com/commaai/panda/pull/1123

car safety
tests
cleanup

On Toyota, the PCM status message (`PCM_CRUISE`) also has the gas pressed bit, so if you for example change some code that should fail a test: ```c if (!cruise_engaged) {...

bug
tests

We should assert we can only ever receive one single or one first frames, in case we are operating with an rx address that is actually a broadcast address and...

bug
enhancement

TODO: catch these bugs with this: - [ ] https://github.com/commaai/panda/pull/1318 - [ ] https://github.com/commaai/panda/pull/1483

The ISO-TP library should be agnostic to the messaging protocol At least support for using some of their service types would be a good start. GM has something very similar...

enhancement

So you don't need to specify the max signal value manually and you can test the whole space. Related/example: https://github.com/commaai/panda/pull/1578

enhancement
tests

When a stock AEB occurs, we assert: - accel is inactive - gas is inactive - `CmbbEngTqMn_B_Rq` in `ACCDATA` is set to 1 to limit engine torque At all times,...

car safety

- [ ] remove GM's existing tests and combine - [ ] handle honda

car safety
tests
cleanup