Shane Smiskol

Results 382 issues of Shane Smiskol

For example, since we don't propagate exceptions from this function, if you pass certain inputs to make_can_msg (like a list instead of dict), you'll get an exception that Python never...

bug

There's a bit in ACC_CONTROL that gets set to 1 (`SG_ MYSTERY_BIT : 28|1@0+ (1,0) [0|1] "" XXX`) whenever the car's stock system starts requesting brake when aEgo is generally...

The signals "AlwaysOne" do not appear to be true, those bits are actually a part of `GasRegenCmd`. An Acadia route, starting at stock signal, expanding signal by one bit closer...

bug
DBC signals

In this segment (`6f63165f17c0e270|2022-03-19--23-09-55--92`), a Genesis had a controls mismatch due to the car sending a message with an invalid checksum so panda stopped allowing messages but we don't check...

bug

Only one DBC in the 8 that imports `_honda_2017.dbc` uses a different `STEERING_SENSORS`. See if we can move this message into the common DBC, and see if that one odd...

bug
cleanup

The problem is how the safety was using the torque samples to enforce the torque winddown. To avoid erroneous blocked messages from panda getting a steer torque message before openpilot,...

car safety
bugfix

## Type of Changes | | Type | | --- | ---------------------- | | ✓ | :bug: Bug fix | ## Description Allows automatic test ref updating to function properly....

Bug :beetle:
Waiting on author
Maintenance
Skip news :mute:
Needs take over 🛎️

Fixes: https://github.com/PyCQA/pylint/issues/7950 TODO: - [x] Update test refs - [x] Make it detect the root abc module correctly

Work in progress
False Negative 🦋
Needs take over 🛎️

### Bug description The message counter is checked first before the output text, so we never have a chance to write the updated output file. Need to flip these two...

Maintenance
Needs PR

### Bug description Related to https://github.com/PyCQA/pylint/issues/3098. Subclasses of an abstract parent class which do not inherit directly from `abc.ABC` are considered abstract, and only throw an error during run time...

False Negative 🦋
Needs PR