Shane Smiskol

Results 1129 comments of Shane Smiskol

2018/19 and 2020 have near-identical camera versions, we really just need to combine these two platforms, not sure if legacy safety mode is needed or not.

@adeebshihadeh The last blocker is the openpilotci and related sources for when we add future segments, they're hard-coded to check for `rlog.bz2` URLs. Are you fine with merging this now,...

Nope, can be changed to anything.

I don't think I was involved in that decision at all, no clue

This is exactly why we can't continue with alt limit flags

You'll want to find a signal that changes when you flip between Autosteer and TACC (if you have those options), and replace it there. We also need to separate this...

I had tried to add pitch compensation to Toyota when trying to understand and undo the internal PCM compensations it does to our acceleration request, but was never able to...

related to https://github.com/commaai/openpilot/pull/32103

Likely a SPI communication issue. All reviewed missing loopback messages coincide with a SPI checksum error cnt increase