Shane Smiskol

Results 1136 comments of Shane Smiskol

Can this car be kept inside the `IONIQ_5` platform?

The wheelbase looks identical (our 2.97 should be 2.99), mass differs due to the battery size (but it already doesn't match exactly for the various trims we support), so that...

You can add `HyundaiFlags.CANFD_NO_RADAR_DISABLE` for now

We've moved the car interfacing code to our [`opendbc`](https://github.com/commaai/opendbc) repository, which is now the new home for car ports and fingerprints. Please re-open your pull request against [`opendbc`](https://github.com/commaai/opendbc) at your...

If not one wants to/has time to open a PR, I can try to tackle it.

~Ah, maybe I'm confused about the relationship of the functional test and the output ref. I assumed that the output text file was a reference we compared the pylint output...

I just meant running pylint on the whole file, ignoring the warning annotations. Disregard.

Radar points do look unusually sparse, especially with cars off to the side

It should pass if you rebase

Looks like it was asserting the previously-first assert's message?