Shane Smiskol

Results 1136 comments of Shane Smiskol

Can you write a quick check with test_models to ensure we don't miss any brake presses we used to catch? Can also use https://huggingface.co/datasets/commaai/commaCarSegments

Mutation test is also failing

Are you sure this works? I set both jerks to 0 and it still happens

This has been an issue for quite a while, it only got worse with the addition of card and the additional 10ms cycle we now wait to respond to engagement...

We will get back to this soon, busy week with the release!

I'm only seeing a reduction of 1s to 0.7s collection time with `pytest --co opendbc` and inconsistent results with the total test time (baseline 25s, one run was 19s, one...

Nice speedup! I can't seem to plot anything and the recommended view is 2D when it probably should be time series. Is there any way to double click/drag or quickly...

`pytest selfdrive/car/tests --co` takes 1.5s on its own.

Here's everything outside of selfdrive/car: ``` =============ation-shane:~/openpilot$ lint-imports Import Linter ============= --------- Contracts --------- Analyzed 454 files, 1075 dependencies. -------------------------------------- Forbid imports from openpilot.selfdrive.car to openpilot.system BROKEN Contracts: 0 kept,...