openpilot icon indicating copy to clipboard operation
openpilot copied to clipboard

fix macos 15.4.1 build

Open greatgitsby opened this issue 7 months ago • 7 comments

resolves: https://github.com/commaai/openpilot/pull/35104

pending: https://github.com/commaai/opendbc/pull/2180 https://github.com/commaai/panda/pull/2196

macos-latest isn't on 15+ yet. adding macos-15 to CI to enforce build success

greatgitsby avatar May 02 '25 15:05 greatgitsby

@sshane you remember why we didn't want to use clang for macOS?

adeebshihadeh avatar May 02 '25 20:05 adeebshihadeh

I don't think I was involved in that decision at all, no clue

sshane avatar May 02 '25 20:05 sshane

Can you evaluate and merge if it makes sense?

adeebshihadeh avatar May 02 '25 20:05 adeebshihadeh

old ref, maybe an unsupported compiler flag: https://github.com/commaai/panda/pull/1241

newer ref from @fredyshox: https://github.com/commaai/panda/pull/1409

EDIT: the original reason was build failure. there are no build failures with normal gcc/clang now because all the compiler flags are supported. this change is fine.

greatgitsby avatar May 02 '25 23:05 greatgitsby

clang17 supports -std=gnu11 which was the original complaint.

-- with .app --

➜ clang --version
Apple clang version 17.0.0 (clang-1700.0.13.3)
Target: arm64-apple-darwin24.4.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

-- with default CommandLineTools version, also supported --

➜ clang --version
Apple clang version 17.0.0 (clang-1700.0.13.3)
Target: arm64-apple-darwin24.4.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin
image

greatgitsby avatar May 02 '25 23:05 greatgitsby

i'll open panda and opendbc PRs with the context and we can get this issue fixed.

greatgitsby avatar May 02 '25 23:05 greatgitsby