Sebastian Ratz

Results 97 comments of Sebastian Ratz

> I tested the code out. Functionality-wise the code uses the new handler when javascript is enabled to capture cursor movements. Thanks for testing and reviewing! > Although, I think...

I've given it some more thought and I think the flag `atLeastOneTopNavigationCompleted` isn't that bad actually. It expresses better why we need the fallback handling.

Test failures on Windows are unrelated.

> I guess there are no plans for releasing Tycho 4.0.10 soon? There are: https://github.com/eclipse-tycho/tycho/discussions/2455#discussioncomment-11140479

The riscv-build2 node on Jenkins currently fails to launch, blocking building of SWT native fragments: https://ci.eclipse.org/releng/computer/riscv%2Dbuild2/

> Can [#1834](https://github.com/eclipse-platform/eclipse.platform.swt/pull/1834) be added to the scope of this issue? Without this sites behind Azure AD authentication (typically in enterprise environment) cannot be loaded with the current Edge implementation....

> Thank you [@ilopezv](https://github.com/ilopezv) and [@martinlippert](https://github.com/martinlippert) for the info. I bet it has something to do with the "modal" pop-ups. See [eclipse-platform/eclipse.platform#1822](https://github.com/eclipse-platform/eclipse.platform/issues/1822) I think it's https://github.com/eclipse-platform/eclipse.platform.swt/issues/1912 (fixed with https://github.com/eclipse-platform/eclipse.platform.swt/pull/1920)

> contributes to #212 I think you mean #1540?

This seems to be a long-standing known Chromium issue: https://bugs.chromium.org/p/chromium/issues/detail?id=113008 I don't think it has any consequences besides the ugly error message.

@akoch-yatta Thanks for catching this in https://github.com/eclipse-platform/eclipse.platform.swt/pull/1450#discussion_r1751957179