eclipse.platform.swt icon indicating copy to clipboard operation
eclipse.platform.swt copied to clipboard

Edge: Use display-relative coordinates in ContextMenuRequested

Open sratz opened this issue 1 year ago • 2 comments

sratz avatar Sep 10 '24 14:09 sratz

@akoch-yatta Thanks for catching this in https://github.com/eclipse-platform/eclipse.platform.swt/pull/1450#discussion_r1751957179

sratz avatar Sep 10 '24 14:09 sratz

Test Results

   486 files  ±0     486 suites  ±0   7m 54s :stopwatch: +43s  4 154 tests ±0   4 146 :white_check_mark: ±0   8 :zzz: ±0  0 :x: ±0  16 370 runs  ±0  16 278 :white_check_mark: ±0  92 :zzz: ±0  0 :x: ±0 

Results for commit 17e6a4cf. ± Comparison against base commit ff514e84.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Sep 10 '24 14:09 github-actions[bot]

I'd also like to get this into M2 as the current behavior is completely broken with anything other than 100% OS zoom level.

sratz avatar Oct 15 '24 14:10 sratz

I'd also like to get this into M2 as the current behavior is completely broken with anything other than 100% OS zoom level.

I agree that we should just merge this for M2. Maybe @amartya4256 can have another look into this? @akoch-yatta may also review the latest change after the merge (when he's back from vacation).

HeikoKlare avatar Oct 15 '24 15:10 HeikoKlare

Test failures are unrelated.

sratz avatar Oct 16 '24 11:10 sratz