Sebastian Ratz

Results 97 comments of Sebastian Ratz

> Currently, `Browser#setLocationForCustomText(String)` returns true exactly when passing `about:blank` into it. Still, we should revise that method (and the discussed provision of such information via the location change event) in...

This change broke working with the DOM in `ProgressListener`s. Consider: ```java public class Demo { public static void main(String[] args) { Display display = Display.getDefault(); Shell shell = new Shell();...

Fix verified in stable version of macOS Sequoia 15.1, so I am closing this now. 👍

> @sratz: Do you have more insights into that? Do you see problems / side effects with this change? This change looks good. By not extending the selection of the...

I missed to merge this change for the M3 deadline :( Any chance this could go in for RC1? The coding is rather safe, especially in the default 'line spacing...

> @sratz > > It is fixing a bug and I trust in your good judgement, so I will defer the decision to you with a +1 from me (the...

I have provided two pull requests in P2 and PDE which allows to configure [``](https://developer.apple.com/documentation/bundleresources/information_property_list/cfbundleurltypes) entries in the macOS app bundle `Info.plist` file via `*.product` definitions: https://github.com/eclipse-equinox/p2/pull/533 https://github.com/eclipse-pde/eclipse.pde/pull/1326

We still need to pre-register the default themes via the new IMacOsBundleUrlType API in the .product files for the several packages: - `eclipse+command` in the Eclipse SDK + runtime binary...

> Alright, I turned this into an actual proposal. I adapted the initial message according to the latest changes and added screenshots to show how it would look like in...

> I like the idea of changing the dialog. I now did it like this: > ![image](https://private-user-images.githubusercontent.com/755472/441256570-f3cb5441-1350-4b5a-ae7b-4e85df506098.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDY3MjI0NjYsIm5iZiI6MTc0NjcyMjE2NiwicGF0aCI6Ii83NTU0NzIvNDQxMjU2NTcwLWYzY2I1NDQxLTEzNTAtNGI1YS1hZTdiLTRlODVkZjUwNjA5OC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwNTA4JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDUwOFQxNjM2MDZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0xOTI1NmRkYmNmNWFkNmRkNzJiNWQzZjkyZDI5OWY4ZDQ4ZmQ4ZTRlOWRhNDE3YzZmZDhjNTY2ZTg5MjU4ZjcwJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.Q5DUapVJveTW4e4dWGTm4lsxlPLM63SYdJxgOGhusNc) > > Clicking on "information" opens the FAQ in an (external) browser. Clicking...