Sebastian Ratz

Results 97 comments of Sebastian Ratz

Re-opening this as we still need https://github.com/eclipse-platform/eclipse.platform.ui/pull/2434 to be merged for this to make a difference.

The feature is now always active, unless overridden in code. Shouldn't this feature be made optional using a preference page and/or coupled to the 'Smart Insert Mode'?

Yes, enabled by default is is fine, but I think there should be a way to disable this functionality, similar to Java-specific preferences: ![Image](https://github.com/user-attachments/assets/20846aef-891d-457a-b2bc-ebc2183a7511)

I was looking at https://github.com/eclipse/gef-classic/wiki/Zest#zest-2x regarding the migration and I am a bit skeptical whether this migration approach is ideal: Ideally, we'd like out product to be compatible with both...

> Both options sound good to me. I would be in favor of option 2, as it might be good to still have the chance to enable the bar. Two...

My proposal for now is this: If https://learn.microsoft.com/en-us/microsoft-edge/webview2/reference/win32/icorewebview2_12 API (handling of status bar) is available: - we disable the internal status bar inside the browser to align Edge with all...

AFAIK all the other browsers consistently use `about:blank` as the location for text written via `setText()`. That means: - `Browser.getext()` returns 'about:blank' - `LocationEvent#location` contains 'about:blank' And there are many...

In general this looks good. Also, with this PR merged, my PR #1451 will become easier, since no more of those `data:text/html;` URLs will appear with the physical file URL...