eclipse.platform.swt icon indicating copy to clipboard operation
eclipse.platform.swt copied to clipboard

Switch back GitHub Actions workflow to use current Tycho version

Open HeikoKlare opened this issue 1 year ago • 1 comments

The Tycho version used in GitHub Actions workflow has been temporarily reverted to 4.0.8. This change switched back the Tycho version defined in the Tycho build itself.

⚠️ This PR is supposed to be merged once the issue discussed in https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/pull/2360 and reproduced via https://github.com/eclipse-tycho/tycho/pull/4293 has been resolved or once we want to have SWT use latest Tycho again to further investigate the failures.

HeikoKlare avatar Sep 25 '24 09:09 HeikoKlare

Test Results

   483 files  ±0     483 suites  ±0   8m 32s ⏱️ -24s  4 095 tests ±0   4 085 ✅ ±0   7 💤 ±0  3 ❌ ±0  16 173 runs  ±0  16 080 ✅ ±0  90 💤 ±0  3 ❌ ±0 

For more details on these failures, see this check.

Results for commit 732b288d. ± Comparison against base commit e03196c6.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Sep 25 '24 09:09 github-actions[bot]

I've experimentally changed this PR to use Tycho 4.0.10-SNAPSHOT, in order to validate that the reason for temporarily switching back to Tycho 4.0.8 (failures during testCompile on Linux/MacOS) has been resolved.

The builds now successfully pass that compilation step (@laeubi fyi). They still fail, but for different, unrelated reasons:

  • Linux: #1564
  • macOS: #1478

I guess there are no plans for releasing Tycho 4.0.10 soon? So would it make sense to upgrade the whole platform to use 4.0.10-SNAPSHOT, or should we maybe at least apply it to the GH actions builds of SWT?

HeikoKlare avatar Nov 05 '24 19:11 HeikoKlare

I guess there are no plans for releasing Tycho 4.0.10 soon?

There are: https://github.com/eclipse-tycho/tycho/discussions/2455#discussioncomment-11140479

sratz avatar Nov 06 '24 03:11 sratz

I guess there are no plans for releasing Tycho 4.0.10 soon? So would it make sense to upgrade the whole platform to use 4.0.10-SNAPSHOT, or should we maybe at least apply it to the GH actions builds of SWT?

We should use 4.0.10-SNAPSHOT for platform to getting more confident that there are no regressions, so if you like just go ahead and upgrade the aggregator for a while, I'll then take care to release the version before the code freeze.

laeubi avatar Nov 06 '24 07:11 laeubi

We should use 4.0.10-SNAPSHOT for platform to getting more confident that there are no regressions, so if you like just go ahead and upgrade the aggregator for a while, I'll then take care to release the version before the code freeze.

Alright, done: https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/pull/2520

HeikoKlare avatar Nov 06 '24 13:11 HeikoKlare

I've changed this PR back to remove the explicit Tycho version specification and use the one of the parent POM again (which is now 4.0.10-SNAPSHOT). I have also integrated the following change into this as otherwise MacOS builds will fail because of changes in API tools:

  • #1478

For failing tests, see: #1564

HeikoKlare avatar Nov 07 '24 13:11 HeikoKlare