Sebastian Ratz

Results 97 comments of Sebastian Ratz

@chrisrueger: Can you sign the ECA with Eclipse? Then we can get this in 2025-09 M1. See https://github.com/eclipse-platform/.github/blob/main/CONTRIBUTING.md#setting-up-your-eclipse-and-github-account

> > @chrisrueger: Can you sign the ECA with Eclipse? Then we can get this in 2025-09 M1. See https://github.com/eclipse-platform/.github/blob/main/CONTRIBUTING.md#setting-up-your-eclipse-and-github-account > > @sratz Hmm I actually have. This is not...

I think it's pretty common for themes to be either dark or light. At least all major operating systems also have this kind of primary boolean distinction.

I agree with @BeckerWdf. Why implement a guessing algorithm when we can make it explicit? Other IDEs also have an explicit flag, e.g. VS Code: https://github.com/microsoft/vscode/blob/544674f984e97b8aa9a444cb5487cfc4c27f2b7a/src/vs/platform/theme/common/theme.ts#L6-L14

Since upgrading our Jenkins agents from Ubuntu 22.04 to 24.04, our test suite also regularly runs into this issue with the latest Eclipse 2025-06. [hs_err_pid2350368.log](https://github.com/user-attachments/files/22074302/hs_err_pid2350368.log) There's also this, which looks...

> And the issue happens with latest 2025-09 release , right? Not sure, I only see this failure in one Jenkins job which currently runs against 2025-06. I'll set up...

The proposed fix in #1743 (for the `Tree`-related crash) looks promising.

> > And the issue happens with latest 2025-09 release , right? > > Not sure, I only see this failure in one Jenkins job which currently runs against 2025-06....

> Our RCP app (and Eclipse itself) seems to need option 1 (`-Xdock:icon=/path/to/icon.icns`) more than it does 3. > > We have both, and removing option 1 leads to the...

When materializing products with P2 (PDE/Tycho), the `.product` configuration: ```xml ``` currently creates the following `Info.plist`: ```xml CFBundleIconFile AppIcon.icns ``` This is legacy as well. To fully make use of...