Benedikt Franke

Results 377 comments of Benedikt Franke

I am not planning to work on this any time soon, but am open to reviewing possible desgins or a merge request. Also, I am not afraid of breaking changes,...

I think this proposal can be generalized. I think arrow functions are fine when assigned to a variable with a type declaration. ```ts type Predicate = (value: unknown) => Boolean:...

I think the rule does not necessarily need to parse the type, it just needs to know if a variable has an explicit type declaration. To me, this seems like...

In this specific case, TypeScript users are pretty much forced to use function expressions if they want to reuse function types. Given function types can be quite complex or even...

Of course it is possible to just declare the type of the function inline. In this contrived example, this is probably fine - and it will compile without issues due...

Support was added a few months ago, this issue can be closed.

PhpStorm 2020.3 does indeed support `array` syntax now. A generalized implementation of generics on iterables still isn't there yet. That being said, I certainly prefer the technically correct annotation of...

Thanks for looking into this @agriffis. I did compare the two tags via https://github.com/styled-components/babel-plugin-styled-components/compare/v1.12.0...v1.12.1, but was intimated by the large number of changed lines. Turns out the actual code changes...

Have you tried adding generics to your own code? I think we should try and add them to this library too, but without having them in your code there is...

Please describe the problem you are trying to solve and how a potential solution could look like.