Benedikt Franke comments

Results 377 comments of


Benedikt Franke

Fixes #1211 shows actual error in debug entries.

Please add a test case to ensure we do not introduce regressions in the future.

Add an option in security config to disable field name suggestions

Implementing this is quite an involved change. A quick search for `suggestion` across the project reveals about a dozen places where information about the schema is leaked through suggestions. Do...

Introduce `TypeReference` that allows linking types together without having to pass a reference to the actual type object or use callbacks

How about `TypeReference` over `DeferredType`? > As soon as the type is needed, it needs to resolve the DeferredType to the actual type. That would require including a type loader...

Introduce `TypeReference` that allows linking types together without having to pass a reference to the actual type object or use callbacks

Wouldn't it be nicer to reference types just by their name? ```php $filters = new InputObjectType([ 'name' => 'StoryFiltersInput', 'fields' => [ 'tags' => [ 'type' => Type::nonNull(Type::listOf('SomeOtherType')), ] ]...

Introduce `TypeReference` that allows linking types together without having to pass a reference to the actual type object or use callbacks

I could see extending the functionality this way, but it is not necessary as a first step. After looking into it a bit further, I can now see the fundamental...

Introduce `TypeReference` that allows linking types together without having to pass a reference to the actual type object or use callbacks

One problem could be that types can be part of multiple schemas. While I have been following the one-schema approach, I know from Lighthouse that there is definite interest in...

Introduce `TypeReference` that allows linking types together without having to pass a reference to the actual type object or use callbacks

I don't mind having the schema take the responsibility of type loading. Perhaps, it can even be beneficial to have context dependent types - for example, a referenced type could...

Introduce `TypeReference` that allows linking types together without having to pass a reference to the actual type object or use callbacks

I am not planning to take on such a large scale change for the upcoming `v15`. It has plenty of breaking changes already and is nearing completion. Maybe after that,...

Pass custom serialize function to EnumType via config

In Lighthouse, we have extended the `EnumType` to be a wrapper around `bensampo/laravel-enum`: - Implementation: https://github.com/nuwave/lighthouse/blob/master/src/Schema/Types/LaravelEnumType.php - Usage: https://github.com/nuwave/lighthouse/blob/master/tests/Unit/Schema/Types/LaravelEnumTypeTest.php I hope that gives you some idea on how you can...

Pass custom serialize function to EnumType via config

I suppose that what you are trying to do is not possible with the type config decorator. It looks like the reference implementation does not support passing a custom `serialize`...