Benedikt Franke

Results 403 comments of Benedikt Franke

> Variant with static public $messageUnknownField = 'Field "% s" is not defined by type% s'; is also suitable, but not entirely convenient, because you will need to extract and...

Forgive my stubbornness, but I still do not see how that is useful. > `$translatedMessages[$messageKey] = $translator->trans($message);` This `trans()` function would have to be really magical in order to produce...

From a maintenance perspective, we should be able to guarantee stable property names (or array keys), rather than stable message contents. If the goal is to make sure that all...

Is is possible to extend the default validation rules. All of them conveniently have the actual error message generation extracted to separate methods, which you can override: https://github.com/webonyx/graphql-php/blob/a5d64c77e77c9d35e6179e5791b23a50c301c760/tests/Validator/CustomRuleTest.php#L19-L55

Aligning the behaviour of this library exactly with graphql-js is difficult due to lazy loading. Given we don't want to eagerly traverse the schema and all its types, how can...

I am not sure what this issue is asking. What needs to change in the library? Maybe you can just create a pull request.

> I think there's still a lot to be done on the SA side What is SA? Can we just use the solution proposed by @vhenzl and ignore possible errors...

I am going to categorize this as a bug, as I believe that serialization of AST nodes should be supported with default PHP settings. A quick fix for you would...

This is a large breaking change, so I will plan this for v16. Until then keep in mind that while static, the standard types can be manipulated dynamically. Unless you...

Relevant: https://github.com/graphql/graphql-js/pull/3049