Benedikt Franke

Results 403 comments of Benedikt Franke

For many complex implementations, we use `graphql-js` as a baseline. It has countless hours and contributions poured into it and is usually correct. It seems like we do not have...

First step towards fixing this is adding a failing test case to https://github.com/webonyx/graphql-php/blob/master/tests/Validator/QueryComplexityTest.php.

This should be a great first PR, a relatively straightforward port of https://github.com/graphql/graphql-js/pull/2733. Any takers? ~Progress on this seems to hang on https://github.com/graphql/graphql-spec/pull/805 though.~ The specification now allows this.

I would like to make the switch when its worth doing. With PHP 8, I would like to redesign quite a few APIs and use named parameters. Let's hold off...

I plan to get to PHPStan `level: max` before.

> Can you please make a bugfix release with PHP 8.1 compatibility? [51ad17c](https://github.com/webonyx/graphql-php/commit/51ad17c3af192e34bc2e368a3c645a5a668f3e15) + #924 Those changes should be present in the latest `14.x` release. If something is missing, please...

> I'm looking forward to the new release and I was running on the master branch in dev as it addressed #934. Is a reason why this fix cannot be...

I just released v15.0.0-alpha.1 - please try it and leave feedback in https://github.com/webonyx/graphql-php/discussions/1231 or open issues.

Static analysis fails: https://github.com/webonyx/graphql-php/runs/7018012660?check_suite_focus=true