Benedikt Franke

Results 377 comments of Benedikt Franke

The fixed version is currently only available under the tag `master`: ![image](https://user-images.githubusercontent.com/12158000/186380028-9618f6d0-17f8-4636-b9d1-ac781cbb1f9d.png)

Where exactly would those directives be defined, can you share an example schema/query?

I really like the idea of having no representation in the payload, and it is great to see that there is already an existing construct that does the same. This...

Great job @benjie, this looks really solid overall.

I would like to another use case that requires this change that might be a bit more common: Deprecation of directives. ```graphql directive @foo on OBJECT @deprecated ```

There are many possibilities on how the test suite could be implemented, as has been discussed in the July 2022 working group meeting. I think it is time for someone...

One possible concern I could see with `GET` requests is the limited length of a URL. Some web server defaults: - [Apache: 8190 bytes](https://httpd.apache.org/docs/2.4/mod/core.html#limitrequestline) - [NGINX: 8 KB](http://nginx.org/en/docs/http/ngx_http_core_module.html#large_client_header_buffers) - [Node:...

This is attempted in https://github.com/laravel/framework/pull/37216

This feature is implemented in Lighthouse - see https://github.com/nuwave/lighthouse/tree/master/src/Tracing.

Looks like a bug in PHPStan, the reassignment of the copy should definitely work. I think the best way forward is to shrink the example to a minimal reproduction and...