Sylwester Arabas comments

Results 518 comments of


                                            Sylwester Arabas

add products for cloud radiative effect

@claresinger let's note down here what would be the next steps to make the issue understandable. Are emissivity and CRE the next steps?

improve diagnostics and error handling in condensation on GPU

addressed in #589

reduce the size of deJong_Mackay_2022/convergence.ipynb notebook (>4MB currently, with all other <1.5MB)

the quick solution would be to add `inline_format='png'` arg to `show_plot()`

reduce the size of deJong_Mackay_2022/convergence.ipynb notebook (>4MB currently, with all other <1.5MB)

we're now enforcing

Condensation failed in parcel environment

@mikhailmints thank you for reporting it! It is very likely that #868 solves the problem - it is a PR in which we switch from theta to supersaturation as a...

Condensation failed in parcel environment

Thank you for the follow ups. Indeed seems it is not related in any way with condensation numerics in PySDM (as the same problem arises with SciPy solver). I confirm...

GPU support for breakup

Here's a recent error caught on CI: ```FAILED tests/unit_tests/dynamics/collisions/test_sdm_breakup.py::TestSDMBreakup::test_single_collision_bounce[ThrustRTC-params0] IndexError: index 2 is out of bounds for axis 0 with size 2 i = 0, j = array([1]), k =...

add smoke tests for deJong figs 10-13 (previously numbered 6 & 7)

Fig. 5 addressed in #962

isub implementation is missing scalar option

Thank you for reporting! Looking at the code of #994 (https://github.com/open-atmos/PySDM/pull/994/files#diff-1ce57f6f2790d1c694b3db8a425ab89c421aeedfe62adfe5df3efd4c18fe09c6R65), this seems to be likely addressed there. Help welcome in reviewing and making #994 mergeable

in tests, replace "return" with "pytest.skip() for tests that are skipped (e.g., many if-GPU conditions)

https://pytest-with-eric.com/pytest-best-practices/pytest-skip-test/#Skip-Test-Function-%E2%80%94-Using-Marker-within-Test-Body