PySDM icon indicating copy to clipboard operation
PySDM copied to clipboard

Published 20 hours ago • verified publisher icon open-atmos

__isub__ implementation is missing scalar option

Open TomMelt opened this issue 2 years ago • 3 comments

https://github.com/open-atmos/PySDM/blob/64a54694dad9ee4d817498ec1fc845716ea184cc/PySDM/backends/impl_numba/storage.py#L60-L69

__isub__ is missing scalar implementation (compare with __iadd__ above)

TomMelt avatar Jul 14 '23 14:07 TomMelt

Thank you for reporting! Looking at the code of #994 (https://github.com/open-atmos/PySDM/pull/994/files#diff-1ce57f6f2790d1c694b3db8a425ab89c421aeedfe62adfe5df3efd4c18fe09c6R65), this seems to be likely addressed there. Help welcome in reviewing and making #994 mergeable

slayoo avatar Jul 21 '23 09:07 slayoo

Stale issue message

github-actions[bot] avatar Sep 19 '23 13:09 github-actions[bot]

Stale issue message

github-actions[bot] avatar Jan 17 '24 13:01 github-actions[bot]