Sylwester Arabas
Sylwester Arabas
closing and reopening to trigger rebuild against current `main` (where the updated `devops_tests` will detect the rendering problem with notebooks caused by buggy PyCharm version)
@bhiogade, thanks! Here are some comments: - [x] there seem to be a clash between `saturated_vaporpressure` and `saturated_vapor_pressure` - [x] let's remove all unused variables (pylint will help) - [...
BTW - [x] it seems that we do not really need to import `numpy` here - worth removing to keep it minimalistic as per the original idea - it should...
the adaptivity scheme for condensation is effective with much lower number of threads than grid cells, which is not true for GPU, in all likelihood, it is more effective to...
that is Bartman_et_al_2021 example
for the record, this likely relates to the precision setting here: https://github.com/open-atmos/PySDM/blob/a6b15528c68a2676aede1d2816dfb70c56f894c9/tests/smoke_tests/parcel/arabas_and_shima_2017/test_conservation.py#L54 which was apparently tighter before, but six significant digits seem OK here? Leaving it closed
Thank you @jtbuch! Let's aim for covering the new logic with unit tests as a part this PR
@jtbuch We use pre-commit to ensure consistent formatting of source files (whitespaces, etc). To make the pre-commit hooks update code automatically before each commit (ensuring pre-commit will pass on CI),...
@jtbuch rebasing onto (or merging in) the current `main` branch should help with the `examples-setup` failure