Sylwester Arabas comments

Results 518 comments of


                                            Sylwester Arabas

add asserts for error norm in Shima smoke test (and report norm in %)

being addressed in #1182 and #1189

Possible error in ThrustRTC handing of numpy float types

Thank you for reporting! One workaround is to use `math.exp` instead of `numpy.exp`: ```python import math from PySDM.backends import GPU a = GPU().Storage.empty((1,), dtype=float) a *= math.exp(1) ``` This behaviour...

add AccretionRate, AutoConversionRate, etc products

+ take size threshold as argument (and the size threshold could be yet another product, like with peak supersaturation)

refactor saturation vapour pressure formulae to avoid using temperatures in Celsius

solved by @Aphus in #1388, thanks!

Titan

we need first to equip PySDM with a way of injecting different values for constants - TODO, keeping open

pylint enabled but still many warnings ignored in the GA workflow

Here is a list of warnings still disabled: PySDM .py files: - [ ] invalid-name - [ ] missing-function-docstring - [ ] missing-class-docstring - [x] missing-module-docstring - [x] too-many-arguments -...

Titan

good news: #631

Titan

BTW, for anyone interested in Titan's clouds, here's a webinar posted today at Youtube: https://www.youtube.com/watch?v=b5kLq2fyNaE

pylint enabled but still many warnings ignored in the GA workflow

let's not try to enforce trailing-whitespace for notebooks!

calculating zero-th moment and other moments (which very often happens in a sequence) should better be done with one API call

in addition, there seem to be a lot of zero-powers computed when calculating the zero-th moment (see `MomentProduct::_download_moment_to_buffer`)