Siddharth Kshetrapal

Results 93 issues of Siddharth Kshetrapal

Thanks for @JoyceZhu for reporting this bug! #### Reproduction: Open this url in firefox: https://primer.style/react/storybook/?path=/story/components-autocomplete--default, it redirects to an empty page. Turns out this happens because `Autocomplete.play` runs on load...

skip changeset

> [!NOTE] > If we want, we can wait until we figure out the semantics for https://github.com/github/primer/issues/3183 to find out if we want to render a `` element at all...

patch release

- Part of https://github.com/github/primer/issues/3170 ### Changelog | Before | After | |--------|--------| | | | ### Rollout strategy - [x] Patch release - [ ] Minor release - [ ]...

patch release
component: SelectPanel
no-breaking-changes: confirmed

There are multiple tests that wrap the rendered component with ThemeProvider: https://github.com/search?q=repo%3Aprimer%2Freact+%3CThemeProvider+path%3Atest.tsx&type=code We do not have to do this anymore because [we already wrap all stories in a ThemeProvider in...

size: sand
react

Running one time unpublish commands

- Fixes https://github.com/primer/react/issues/3947 - Includes https://github.com/primer/react/pull/3958 > [!WARNING] > **Possible breaking changes?** > > This PR affects Portals, so all overlays with width:auto would now be able to grow like...

no-breaking-changes: need to test

### The problem: When an html `` is not "open", it has the dimensions of 0px by 0px, which means the anchored position is not able to calculate if the...

component: SelectPanel
no-breaking-changes: need to test

`primer-react/no-system-props` was not checking stories because it did not consider the import to be from `@primer/react` - Fully expecting [a bunch of linting errors](https://github.com/primer/react/actions/runs/8189291072/job/22393719678?pr=4366) some of them will be fixed...

Stale
skip changeset

```diff - swatch-sid.vercel.app/?mode=light&token=accent.fg + swatch-primer.vercel.app/?mode=light&token=accent.fg ```

(Do not merge, see demo in https://github.com/github/primer/issues/2008#issuecomment-1604286039) This is a first draft, the implementation is based on running filter functions on generated variables (`tokens-next-private/**/*.css` Example: ```jsx paddingBlock: ({type, name, file})...