react
react copied to clipboard
eslint: Really enable primer-react/no-system-props
primer-react/no-system-props
was not checking stories because it did not consider the import to be from @primer/react
- Fully expecting a bunch of linting errors
some of them will be fixed by
- https://github.com/primer/eslint-plugin-primer-react/pull/148
- https://github.com/primer/eslint-plugin-primer-react/pull/149
- https://github.com/primer/eslint-plugin-primer-react/pull/151
- https://github.com/primer/eslint-plugin-primer-react/pull/152
Rollout strategy
- [ ] Patch release
- [ ] Minor release
- [ ] Major release; if selected, include a written rollout or migration plan
- [x] None; if selected, include a brief description as to why
Internal only.
Merge checklist
- NA Added/updated tests
- NA Added/updated documentation
- NA Added/updated previews (Storybook)
- NA Changes are SSR compatible
- NA Tested in Chrome
- NA Tested in Firefox
- NA Tested in Safari
- NA Tested in Edge
- NA (GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)
⚠️ No Changeset found
Latest commit: 7b705c1f103d3f757ca50f5b4cc24a302ba1d2ed
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
size-limit report 📦
Path | Size |
---|---|
packages/react/dist/browser.esm.js | 113.71 KB (0%) |
packages/react/dist/browser.umd.js | 114.38 KB (0%) |
Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.