feat: Add config to only run peak shaving controller on peaks
This is done so that it can be combined with for instance the time of use controller
Thanks for the PR. I've been thinking about a similar functionality, but would prefer a different approach:
enableRecharge = falsecan already be achieved by settingrechargePowerto a very small value (e.g.0or negative)- instead of setting a fixed value with
ess.setActivePowerEquals(), set a minimum (ActivePowerGreaterOrEquals) or maximum (ActivePowerLessOrEquals) respectively for peak-shaving and recharging.
This way Controller does not have to know if there is another Controller coming afterwards.
What do you think?
enableRecharge = falsecan already be achieved by settingrechargePowerto a very small value (e.g.0or negative)
yes this we can do together with the no longer setting of 0 when both peak-shaving and recharging is not needed
- instead of setting a fixed value with
ess.setActivePowerEquals(), set a minimum (ActivePowerGreaterOrEquals) or maximum (ActivePowerLessOrEquals) respectively for peak-shaving and recharging.
we can and i think should do this, but it will still not be a optional peakshaving if we keep the set to 0 if there is no peak or recharge moment, and if we remove that part it will stay at the last given value if the controller is running stand alone (so no other controller running after it)
This PR has been automatically marked as stale due to inactivity. It will be closed in 7 days if no further activity occurs.
This PR has been closed due to inactivity
It was automatically closed because there has been no recent activity. If the PR is still relevant, please feel free to reopen and update it and add any new information.