openems icon indicating copy to clipboard operation
openems copied to clipboard

feat: Add config to only run peak shaving controller on peaks

Open nlamarti opened this issue 1 year ago • 3 comments

This is done so that it can be combined with for instance the time of use controller

nlamarti avatar May 11 '24 09:05 nlamarti

Code Coverage

github-actions[bot] avatar May 11 '24 10:05 github-actions[bot]

Thanks for the PR. I've been thinking about a similar functionality, but would prefer a different approach:

  • enableRecharge = false can already be achieved by setting rechargePower to a very small value (e.g. 0 or negative)
  • instead of setting a fixed value with ess.setActivePowerEquals(), set a minimum (ActivePowerGreaterOrEquals) or maximum (ActivePowerLessOrEquals) respectively for peak-shaving and recharging.

This way Controller does not have to know if there is another Controller coming afterwards.

What do you think?

sfeilmeier avatar May 27 '24 15:05 sfeilmeier

  • enableRecharge = false can already be achieved by setting rechargePower to a very small value (e.g. 0 or negative)

yes this we can do together with the no longer setting of 0 when both peak-shaving and recharging is not needed

  • instead of setting a fixed value with ess.setActivePowerEquals(), set a minimum (ActivePowerGreaterOrEquals) or maximum (ActivePowerLessOrEquals) respectively for peak-shaving and recharging.

we can and i think should do this, but it will still not be a optional peakshaving if we keep the set to 0 if there is no peak or recharge moment, and if we remove that part it will stay at the last given value if the controller is running stand alone (so no other controller running after it)

nlamarti avatar May 31 '24 10:05 nlamarti

This PR has been automatically marked as stale due to inactivity. It will be closed in 7 days if no further activity occurs.

github-actions[bot] avatar Sep 19 '25 02:09 github-actions[bot]

This PR has been closed due to inactivity

It was automatically closed because there has been no recent activity. If the PR is still relevant, please feel free to reopen and update it and add any new information.

github-actions[bot] avatar Oct 11 '25 02:10 github-actions[bot]