openems icon indicating copy to clipboard operation
openems copied to clipboard

UI: Masonry layout for widgets

Open da-Kai opened this issue 1 year ago • 1 comments

Aktuell

Bildschirmfoto am 2024-10-18 um 18 02 25

Masonry Layout

Bildschirmfoto am 2024-10-18 um 18 01 06

da-Kai avatar Oct 18 '24 16:10 da-Kai

Codecov Report

Attention: Patch coverage is 4.76190% with 20 lines in your changes missing coverage. Please review.

:x: Your patch status has failed because the patch coverage (4.77%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2845      +/-   ##
=============================================
+ Coverage      58.84%   58.85%   +0.01%     
  Complexity       173      173              
=============================================
  Files           2619     2619              
  Lines         113026   113046      +20     
  Branches        8317     8319       +2     
=============================================
+ Hits           66494    66517      +23     
+ Misses         44039    44038       -1     
+ Partials        2493     2491       -2     
:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Oct 18 '24 16:10 codecov[bot]

@lukasrgr Ich hab die Implementierung jetzt so geändert, dass die reihenfolge gleich bleibt

openems-masonry

da-Kai avatar Oct 25 '24 18:10 da-Kai

Just a little Information for you @da-Kai - I tried this and it basically scrumbled up sometimes all Widgets as they got rendered too slow because of the slower Channel Population of some Components - either we need to increase the Timeout here:

https://github.com/OpenEMS/openems/pull/2845/files#diff-b001e10dc95932dfad86e0e988df71e34fafc7fa94c3457d65707af3d19f8a07R49

or find another solution for it i guess ? :)

Edit: The CSS does not get applied correctly if the Container is getting bigger after Channel Population. This leads to Overlapping Cards for example. I also got it from time to Time, that the Cards were just above each other on the top left upper corner, where nothing could be seen anymore. JFYI

Greetings !

Sn0w3y avatar Nov 15 '24 05:11 Sn0w3y

Hi @Sn0w3y, If you don't mind, could you test it again?

da-Kai avatar May 31 '25 08:05 da-Kai

Hi @Sn0w3y, If you don't mind, could you test it again?

Sure, i already saw you changed things - will test it and Report as soon as I did - just had no time right now to do so :)

Sn0w3y avatar May 31 '25 10:05 Sn0w3y

@da-Kai This layout will become obsolete with the new navigation (see prototype in EVSE)

sfeilmeier avatar May 31 '25 21:05 sfeilmeier

@da-Kai This layout will become obsolete with the new navigation (see prototype in EVSE)

Hi Stefan, is there a Sneak-Peak available?

Sn0w3y avatar May 31 '25 21:05 Sn0w3y

@Sn0w3y It's still very much work-in-progress and no-UI/UX-designers-involved-yet, but these are two recent screenshots of the mobile App with a new multi-level, bottom navigation approach:

grafik

sfeilmeier avatar May 31 '25 21:05 sfeilmeier