Özkan Sezer

Results 570 comments of Özkan Sezer

> I do resume - it REWINDS to begin, and plays from begining of the song: Hmm, the patch calls `fluidsynth.fluid_player_seek(music->player, 0);` in `FLUIDSYNTH_Stop()` which is probably a mistake..

As far as I can see, no other music code under codecs/ rewind to 0 in their stop procedure, so we shouldn't do that in fluidsynth either. @slouken?

@TheCycoONE: I think @Wohlstand is referring to SDL_mixer calls I think the patch is acceptable after removing the offending rewind call from the _STOP procedure, like: ```diff diff --git a/src/codecs/music_fluidsynth.c...

> I made another solution: I think all those and your changes are specific to your own fork, yes?

> > I made another solution: > > I think all those and your changes are specific to your own fork, yes? Oh hell, never mind -- `IsPlaying` is already...

About `return music->is_paused || fluidsynth.fluid_player_get_status(music->player) == FLUID_PLAYER_PLAYING ? SDL_TRUE : SDL_FALSE;` Is it not supposed to be like: ```c return ( !music->is_paused && fluidsynth.fluid_player_get_status(music->player) == FLUID_PLAYER_PLAYING) ? SDL_TRUE : SDL_FALSE;...

Also: You keep the rewinding call in FLUIDSYNTH_Stop() : If I remove it as I described above by removing seek-to-0 call, `playmus -i xxx.mid` seems to work as expected without...

It is all contradictory with music_timidity and timidity. But I'm confused enough, and won't bother more. Letting you and @slouken to decide and finalize this.

Well, just tried it, and playmus program reports wrong position and 0 duration for a midi file I tried. So there is definitely something wrong with the patch. And I...

I'm afraid it'll turn out to be way too much trouble than it's worth and we'll have to revert the patches