Özkan Sezer
Özkan Sezer
@icculus, @slouken: Please review the SDL_mixer-1.2 patch above until @SupSuper has a chance to test it.
> However, your patch that replaces SDL_free with SDL_FreeWAV fixes the problem, so I guess there's still some subtle difference between the two. That's great, I'll apply the patch to...
Has this patch been reviewed / well-tested?
OK, thanks.
Does it build / work on windows versions too?
Is this planned for 2.20 ?
The patch does not apply: you generated against an older git revision. It seems like you miss this commit: https://github.com/libsdl-org/SDL_ttf/commit/8368ea92c8bb86d65dd28ba10eeeeecefbd7d214
> it can be discarded, because I have rewritten that part in the code. You should rebase your patchset, instead.
> If you don't mind my asking, why squash it now when it can be squashed at merge? Because otherwise it's rude, and severely hinders other ways of testing PR...
Josiah submitted a similar patch to qs too, but I don't have anything to test it with so I requested reviews from @ericwa or @andrei-drexler