Özkan Sezer
Özkan Sezer
Haven't tested this vkquake version of the patch, but the test map/progs you gave above rendered broken for qs -- see https://github.com/sezero/quakespasm/pull/32#issuecomment-1202006404
> @sezero, you just removed the custom Watcom Makefiles, is this something you still want? No, we don't want this anymore
The midi files support (load_mid, load_pat, load_abc) in libmodplug is _bad_ and should die. I specifically disable it in my fork, SDL_sound removed it in its fork and went back...
Fixes C89 build failures in CI: ```diff diff --git a/src/physfs.c b/src/physfs.c index 998157c..958b784 100644 --- a/src/physfs.c +++ b/src/physfs.c @@ -3498,10 +3498,11 @@ static int doDeinitContext(Context *context) { int PHYSFS_initContext(PHYSFS_Context _context,...
Re-opening after fixing accidental screw-up.
@AliceLR: Pushed f93b2554 to load_med.c. And yes: The other places are crawling with similar issues.
> This seems about as fine as it can be without a much larger overhaul. Other loaders will need similar changes, but yes it will be a much larger patch
> Am I correct in thinking that this PR is meant to fix big endian compatibility as well? Yes (even though the comments in there say that it is big-endian-fixed)...
I don't have anything, at the moment. There is https://github.com/icculus/SDL_sound/pull/97, though, for #92 (last I looked at it, discussion hadn't arrived anywhere.)
These are fixed in current git master - this should be closed.