SDL_ttf icon indicating copy to clipboard operation
SDL_ttf copied to clipboard

Re-enable HAVE_NEON_INTRINSICS

Open 1bsyl opened this issue 2 years ago • 7 comments

It seems to me ARM_NEON is working and could be re-activated: https://github.com/libsdl-org/SDL_ttf/blob/main/SDL_ttf.c#L122

diff --git a/SDL_ttf.c b/SDL_ttf.c
index 8a4bb3d..68909ea 100644
--- a/SDL_ttf.c
+++ b/SDL_ttf.c
@@ -119,7 +119,7 @@ int TTF_SetScript(int script) /* hb_script_t */
 #endif
 
 /* Round glyph width to 16 bytes use NEON instructions */
-#if 0 /*defined(__ARM_NEON)*/
+#if defined(__ARM_NEON)
 #  define HAVE_NEON_INTRINSICS 1
 #endif

1bsyl avatar May 14 '22 09:05 1bsyl

Does it build / work on windows versions too?

sezero avatar May 14 '22 10:05 sezero

I haven't re-tried that, I think it did (window for window arm platform). never try compiling on windows for android. I probably can double-check (later..)

1bsyl avatar May 14 '22 11:05 1bsyl

What testing have you done to verify it?

slouken avatar May 16 '22 17:05 slouken

I haven't done more testing recently. (I'll try the window compilation more later). I don't know why this is back-out. I've using these neon intrinsic routines for years now on android without special crash about it

1bsyl avatar May 16 '22 18:05 1bsyl

I have some trouble to try the ARM compilation of SDL_ttf on window. I have no device, my Visual Studio is old (2017) and not configured for ARM. Would be nice if someone with a setup ready could try it.

1bsyl avatar May 19 '22 05:05 1bsyl

Is this planned for 2.20 ?

sezero avatar Jun 29 '22 02:06 sezero

Is this planned for 2.20 ?

No, nobody has a setup to test it, so it'll have to go in post-release.

slouken avatar Jun 29 '22 03:06 slouken