Özkan Sezer

Then we should just remove the underscore thing from there and close this ticket, yes?

Created https://github.com/libsdl-org/SDL/pull/6443 for this

Got the following build errors on an old setup: ``` src/video/x11/SDL_x11pen.c: In function ‘X11_InitPen’: src/video/x11/SDL_x11pen.c:65: error: ‘bool’ undeclared (first use in this function) src/video/x11/SDL_x11pen.c:65: error: (Each undeclared identifier is reported...

Yes: if there are no changes to configure.ac, please revert changes to generated configure. Yes: Squashing into a single commit and force-pushing into this PR would make reviewing easier. Thanks.

> I merged against `main` to keep up to date, but this adds a lot of commits to this PR. Do you prefer that I rebase against `main` and force-push...

For most compatibility with many compilers, testpen.c can lose C99'isms ```diff --- testpen.c~ +++ testpen.c @@ -46,7 +46,8 @@ DrawScreen(SDL_Renderer *renderer) if (last_was_eraser) { - SDL_Rect rect = { -...

`testautomation_pen.c` fails build for me. From watcom: ``` testautomation_pen.c(745): Error! E1030: Cannot take the address of an rvalue ``` From gcc: ``` testautomation_pen.c: In function 'pen_hotplugging': testautomation_pen.c:745: error: invalid use...

Watcom doesn't seem to accept initialization code for `simulated_pen_action steps[]`, so just simply disable it: ```diff diff --git a/test/Makefile.os2 b/test/Makefile.os2 index 3b0b4c8..a243314 100644 --- a/test/Makefile.os2 +++ b/test/Makefile.os2 @@ -25,3 +25,3...

The os/2 test builds if I do the following: ```diff diff --git a/test/testautomation_pen.c b/test/testautomation_pen.c index 107996c..d763e0e 100644 --- a/test/testautomation_pen.c +++ b/test/testautomation_pen.c @@ -1067,5 +1067,5 @@ pen_movementAndAxes(void *arg) SDL_Event event; -...

You can use SDL_snprintf instead of sprintf - try this? ```diff diff --git a/src/events/SDL_pen.c b/src/events/SDL_pen.c index aaa1903..99d6fc4 100644 --- a/src/events/SDL_pen.c +++ b/src/events/SDL_pen.c @@ -22,10 +22,6 @@ /* Pressure-sensitive pen handling...