sean-brydon
sean-brydon
Note : e2e suite has some failing test but it isn’t shown with the new changes
@PeerRich what is the reason for this? Its generally recommended to avoid disabling pinch to zoom as its not the best thing to do for a11y.
> @sean-brydon zooming on mobile apps looks weird and breaks the pwa experience. i dont mind keeping it, just looks weird. visit the mobile page and pinch to zoom, looks...
> [sean-brydon](https://github.com/sean-brydon) I think I can check it conditionally. If there is a passthrough then we use it, otherwise use the reactId Agreed - thanks for making the change :)
Already implemented
I dont see any issue with the filters bar being scrollable when on mobile honestly. Happy with how this is currently. Would like the issue i mentioned to be fixed...
Thanks for the contribution @VinoV1999 closing in favour of https://github.com/calcom/cal.com/pull/9198?no-redirect=1 as it was a cleaner approach!
Fixed by https://github.com/calcom/cal.com/pull/9198
> Yeah I agree that it's not a good UX. But I think (as I mentioned in TODO) a dialog is more appropriate here. We have no implementation of Dialog...
Go for it @alfredlouisw8 :)