cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

fix: Text beyond the X icon fix

Open VinoV1999 opened this issue 2 years ago • 4 comments
trafficstars

What does this PR do?

prevents text to not go behind the cross sysmbol if cross symbol visible.

Fixes #8976

Type of change

  • passed classname attribute

ScreehShot:-

Screenshot 2023-05-19 at 8 49 19 AM

VinoV1999 avatar May 19 '23 03:05 VinoV1999

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 19, 2023 8:01pm

vercel[bot] avatar May 19 '23 03:05 vercel[bot]

Someone is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar May 19 '23 03:05 vercel[bot]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions[bot] avatar May 19 '23 03:05 github-actions[bot]

Lets rethink the approach for handling the X button here - We could look at using TextField component that already supports addonleading

cal/packages/ui/components/form/inputs/Input.tsx

How about these two kinds of changes, I'll create the pr if any of them is fine @Udit-takkar @sean-brydon @hariombalhara

image 2. image

VasuDevrani avatar May 28 '23 07:05 VasuDevrani

Thanks for the contribution @VinoV1999

closing in favour of https://github.com/calcom/cal.com/pull/9198?no-redirect=1 as it was a cleaner approach!

sean-brydon avatar May 30 '23 09:05 sean-brydon