sean-brydon

Results 153 comments of sean-brydon

@hariombalhara here is the example below without local state. (I dont like it) ![CleanShot 2023-05-05 at 15 25 58](https://user-images.githubusercontent.com/55134778/236486184-b207044f-3417-453f-b10f-50e8fd0ace1c.gif) I personally much prefer having the switch be responsive as soon...

> @sean-brydon My reasoning for it is the same as there for the `Save` button(except that it has a possibly larger payload and can take more time). When you click...

> Sure @sean-brydon. Totally makes sense. It's a miss on my part that I didn't notice it's an important fix. No worries! The delay between api calls is (with no...

Thanks for fixing the issues addressed - The reset button doesnt seem to hide when the values are default

> @MaheshB77, @Udit-takkar Just a suggestion that don't you think the hover effect on the set as default button should be bg-subtle, I checked the toggle button in event-type/[id] it...

> > > @MaheshB77, @Udit-takkar Just a suggestion that don't you think the hover effect on the set as default button should be bg-subtle, I checked the toggle button in...

Thanks for your contribution! Closing in favour of https://github.com/calcom/cal.com/pull/8696 as this fixes the issue in multiple places an uses our new token colours! Nice job tho! Let me know if...

Hi @elhadis thanks for the contribution - I'm not exactly sure what this PR is trying to do but it doesnt seem to be link to the issue you mentioned...

> > sorry @vaibhav135 I will have to close this PR in favour of #8677 > > @Udit-takkar I did used the local state initially and @hariombalhara recommended me to...

> > sorry @vaibhav135 I will have to close this PR in favour of #8677 > > @Udit-takkar I did used the local state initially and @hariombalhara recommended me to...